Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Redesign CNF installation process #2120

Closed
kosstennbl opened this issue Jul 31, 2024 · 1 comment
Closed

[EPIC] Redesign CNF installation process #2120

kosstennbl opened this issue Jul 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kosstennbl
Copy link
Collaborator

kosstennbl commented Jul 31, 2024 •
edited
Loading

[EPIC] Redesign CNF installation process

Current installation process is quite limiting and hard to maintain. Multiple issues are already created and they only build up: #2095, #2106, #2036.

The idea is to redesign CNF installation process in a way that fixes some of the current issues and makes it easier to expand installation functionality (and possibly, in the future, make addition of new installation methods much easier).

Central idea of this change is to install CNFs in different ways, but then gather all installed resources as manifest files. Then, during testing, all tests would have to work only with manifest files regardless of installation method of CNF.

This planned redesign seems to be quite complex and time-consuming, so better approach would be to split it into several different issues and PRs, the following is the plan for the change (up to discussion, can be changed):

  1. Implement new cnf-testsuite.yml config format and its parsing ([Feature] CNF installation (1), Implement new config format #2121).
  2. Implement additional functionality tied to configuration.
    1. Implement a way to transform old configs into new format.
    2. Implement generate_config for new format.
  3. Rewrite all sample/example CNF configs and change default config format to new one.
  4. Implement a way to create common manifest, use it for all tests that require manifest ([Feature] CNF installation (4), Create and use common manifest #2125).
  5. Redesign tests that are not compliant with the common manifest or require deployment type-specific functionality to function.
  6. Prepare new installation process (and multiple charts support as a part of this).
  7. Check how specs would be affected, prepare for required fixes.
  8. Switch to new installation (use all prepared code), fix tests, remove old code.

It is planned to create GitHub issues and link them there when they would be ready for start.
This issue should be resolved as soon as all connected issues and tasks are completed.
@kosstennbl kosstennbl added the enhancement New feature or request label Jul 31, 2024
This was referenced Aug 1, 2024
Closed
Closed
This was referenced Aug 9, 2024
Closed
Closed
@kosstennbl kosstennbl mentioned this issue Aug 15, 2024
Closed
@kosstennbl kosstennbl mentioned this issue Sep 4, 2024
Open
@martin-mat martin-mat mentioned this issue Sep 12, 2024
Open
@svteb svteb mentioned this issue Sep 16, 2024
Merged
20 tasks
@svteb svteb mentioned this issue Sep 30, 2024
Merged
20 tasks
@svteb svteb mentioned this issue Dec 3, 2024
Closed
@svteb
Copy link
Collaborator

svteb commented Dec 3, 2024

Finally finished! The last pull request #2171 has been successfully merged.

@svteb svteb closed this as completed Dec 3, 2024
@svteb svteb mentioned this issue Jan 16, 2025
Open
svteb added a commit that referenced this issue Jan 16, 2025
@svteb
Fix: Repair "uninstall_all"
6db5733 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
collivier pushed a commit that referenced this issue Jan 16, 2025
@svteb @collivier
Fix: Repair "uninstall_all"
21ca63c 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Jan 17, 2025
@svteb
Fix: Repair "uninstall_all"
9e4c736 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Jan 17, 2025
@svteb
Fix: Repair "uninstall_all"
0c2e2e6 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Jan 17, 2025
@svteb
Fix: Repair "uninstall_all"
662820f 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Jan 17, 2025
@svteb
Fix: Repair "uninstall_all"
11f72f1 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Jan 17, 2025
@svteb
Fix: Repair "uninstall_all"
d7d704a 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
martin-mat pushed a commit that referenced this issue Jan 17, 2025
@svteb @martin-mat
Fix: Repair "uninstall_all"
6cf5a94 
Refs: #2209
- The "uninstall_all" was broken during development of #2120,
to fix the issue a failure when there is no CNF to uninstall
has been relegated to a warning and exit 1 was removed.
- Two spec tests have been added to avoid this scenario
in the future.
- Additionally some renaming was left-over from #2184 that
was resolved.

Signed-off-by: svteb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kosstennbl @svteb