Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all github actions #2186

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

collivier
Copy link
Collaborator

Description

v3 is deprecated [1].
It will remove 50+ warnings

[1] https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

@collivier collivier force-pushed the update_githubactions branch from 14f172d to 8e36172 Compare December 3, 2024 09:51
@martin-mat martin-mat self-requested a review December 3, 2024 16:22
v3 is deprecated [1] so this change removes 50+ warnings.

Please note that due to how Artifacts are created in this new version,
it is no longer possible to upload to the same named Artifact multiple times [2].

: is replaced by _ in specs as it forbids publishing artifacts

[1] https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
[2] https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Signed-off-by: Cédric Ollivier <[email protected]>
Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collivier
Copy link
Collaborator Author

it must be merged as it's a key fix and the workflows are passing well.

@collivier collivier merged commit 0e8d604 into cnti-testcatalog:main Dec 6, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants