Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid 2 artifact conflicts #2190

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Avoid 2 artifact conflicts #2190

merged 1 commit into from
Dec 9, 2024

Conversation

collivier
Copy link
Collaborator

Description

Avoid 2 artifact conflicts:

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • main
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

martin-mat
martin-mat approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

svteb
svteb approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@svteb svteb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@collivier collivier merged commit 8cae903 into cnti-testcatalog:main Dec 9, 2024
83 checks passed
@collivier collivier deleted the avoid_artifact_conflicts branch December 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svteb svteb svteb approved these changes

@martin-mat martin-mat martin-mat approved these changes

@Smitholi67 Smitholi67 Awaiting requested review from Smitholi67

@kosstennbl kosstennbl Awaiting requested review from kosstennbl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@collivier @martin-mat @svteb