Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid too many pull requests because of skopeo #2203

Closed
wants to merge 4 commits into from

Conversation

collivier
Copy link
Collaborator

@collivier collivier commented Jan 8, 2025

Description

skopeo directly pulls from docker.io which easily reaches the pull rate limit.

Please see shared_database and observability failing because of skopeo
(whatever the use of private mirror or mirror.gcr.io):

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

@collivier collivier changed the title Revert "Stop using local registry" Leverage mirror to avoid too many pull requests because of skopeo Jan 12, 2025
@collivier collivier force-pushed the mirror branch 3 times, most recently from 5bd1ada to bf04b57 Compare January 14, 2025 14:51
@collivier collivier changed the title Leverage mirror to avoid too many pull requests because of skopeo Avoid too many pull requests because of skopeo Jan 14, 2025
@collivier collivier force-pushed the mirror branch 5 times, most recently from 367b652 to a5d2244 Compare January 14, 2025 18:42
It includes the fix stopping passing stdin
to the container.

Signed-off-by: Cédric Ollivier <[email protected]>
It includes the fix avoiding too many pull requests
because of skopeo [1].

cnf-testsuite/cluster_tools#30

Signed-off-by: Cédric Ollivier <[email protected]>
Signed-off-by: Cédric Ollivier <[email protected]>
Bitnami moved to Docker Hub [1] which forces us to login to
Docker Hub (the workflow pulls too much Bitnami helm charts
for the anon pull request limit).

Please note the Docker Hub secrets are accessible only via
project branches. So PR from fork would no longer work.

It also updates and simplifies the Docker Hub account logics
as we have a single Docker Hub account now. It also debugs
ratelimit both with registered account and anon to track
incorrect Docker Hub calls by cnf-testsuite.

[1] bitnami/containers#75671

Signed-off-by: Cédric Ollivier <[email protected]>
@collivier
Copy link
Collaborator Author

it must be exected from branch now

@collivier collivier closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant