-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactionalize #9
Conversation
Also, for symmetry's sake, I added the functionality to both sides: |
@cocagne Is there anything I can do to ease the integration of this? |
Thanks Nelz. I'm currently attending the Storage Developers Conference and Tom
|
Looks really good overall Nelz. Just a few standard pointer handling issues and memory leaks to address before merging. |
I've addressed most of your comments, except for the bit around single- vs. double-pointers, which I commented on above. (Please pardon my slowness, it's been a LONG time since I've done any C, and I've been super reliant on https://github.com/radii for his C excellence.) |
Transactionalize, courtesy of nelz9999
Awesome! Thanks! |
No problem. Thanks for the patch. If you don't see the new version up on Tom On Tue, Sep 30, 2014 at 1:09 PM, Nelz [email protected] wrote:
|
This is the candidate work to address Issue #6.
Builds upon PR #8...
Most of the changes are procedural, but the change in OnBeep@11ac6eb affects the randomness of the ephemeral values by sacrificing a single bit (out of 256) of entropy in favor of enforcing a 32-byte representation.