Skip to content

Commit

Permalink
roachtest: update activerecord and ruby-g expected failures
Browse files Browse the repository at this point in the history
- Mark 2 activerecord tests as flaky.
- Mark 4 ruby-pg tests as passing after
  #138709 was merged.

Release note: None
  • Loading branch information
rafiss committed Jan 13, 2025
1 parent 04a987e commit 926f5ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions pkg/cmd/roachtest/tests/activerecord_blocklist.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ var activeRecordIgnoreList = blocklist{
`BasicsTest#test_default_values_are_deeply_dupped`: "flaky",
`CockroachDB::FixturesTest#test_create_fixtures`: "flaky",
`FixtureWithSetModelClassPrevailsOverNamingConventionTest#test_model_class_in_fixture_file_is_respected`: "flaky",
`InheritanceTest#test_eager_load_belongs_to_primary_key_quoting`: "flaky",
`InheritanceTest#test_eager_load_belongs_to_something_inherited`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "flaky",
`TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "flaky",
Expand Down
4 changes: 0 additions & 4 deletions pkg/cmd/roachtest/tests/ruby_pg_blocklist.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ var rubyPGBlocklist = blocklist{
`PG::Connection multinationalization support Ruby 1.9.x default_internal encoding allows users of the async interface to set the client_encoding to the default_internal`: "unknown",
`PG::Connection multinationalization support Ruby 1.9.x default_internal encoding honors the Encoding.default_internal if it's set and the synchronous interface is used`: "unknown",
`PG::Connection multinationalization support encodes exception messages with the connection's encoding (#96)`: "unknown",
`PG::Connection multinationalization support handles clearing result in or after set_notice_receiver`: "unknown",
`PG::Connection multinationalization support receives properly encoded messages in the notice callbacks`: "unknown",
`PG::Connection multinationalization support receives properly encoded text from wait_for_notify`: "unknown",
`PG::Connection multinationalization support respect and convert character encoding of input strings should convert query string and parameters to #exec_params`: "unknown",
`PG::Connection multinationalization support respect and convert character encoding of input strings should convert query string and parameters to #send_query_params`: "unknown",
Expand Down Expand Up @@ -132,8 +130,6 @@ var rubyPGBlocklist = blocklist{
`running with sync_* methods PG::Connection multinationalization support Ruby 1.9.x default_internal encoding allows users of the async interface to set the client_encoding to the default_internal`: "unknown",
`running with sync_* methods PG::Connection multinationalization support Ruby 1.9.x default_internal encoding honors the Encoding.default_internal if it's set and the synchronous interface is used`: "unknown",
`running with sync_* methods PG::Connection multinationalization support encodes exception messages with the connection's encoding (#96)`: "unknown",
`running with sync_* methods PG::Connection multinationalization support handles clearing result in or after set_notice_receiver`: "unknown",
`running with sync_* methods PG::Connection multinationalization support receives properly encoded messages in the notice callbacks`: "unknown",
`running with sync_* methods PG::Connection multinationalization support receives properly encoded text from wait_for_notify`: "unknown",
`running with sync_* methods PG::Connection multinationalization support respect and convert character encoding of input strings should convert query string and parameters to #exec_params`: "unknown",
`running with sync_* methods PG::Connection multinationalization support respect and convert character encoding of input strings should convert query string and parameters to #send_query_params`: "unknown",
Expand Down

0 comments on commit 926f5ed

Please sign in to comment.