Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add drtprod wrapper for managing drt clusters #120056

Merged
merged 1 commit into from
Mar 10, 2024
Merged

scripts: add drtprod wrapper for managing drt clusters #120056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions scripts/drtprod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/env bash

# drtprod is a wrapper for roachprod for use when managing the long-lived DRT
# clusters that ensures consistent use of the correct project-assignment vars
# and done some additional sanity check enforcement on some flags.

if [[ $1 == "start" ]]; then
if [[ "$*" != *"--secure"* ]]; then
echo "--secure is required when starting DRT clusters"
exit 1
fi
if [[ "$*" != *"--sql-port 26257"* ]]; then
Copy link
Collaborator

@herkolategan herkolategan Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, I added some additional checks in roachprod to prevent using DNS/services on clusters that do not support it. See #120141
Once that is merged the logic here will hopefully not be necessary anymore.

# we don't use service discovery in our the drt project so use default port.
echo "--sql-port 26257 is required when starting DRT clusters"
exit 1
fi
fi

GCE_PROJECT=cockroach-drt ROACHPROD_DNS="drt.crdb.io" roachprod "$@"
Loading