Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump Pebble to 3748221737d4 #138980

Merged

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Jan 13, 2025

Changes:

  • 37482217 sstable/block: add Reader type
  • 8d3363b3 sstable/block: move category stats, read env
  • a18792eb sstable: use errorfs in TestIteratorErrorOnInit

Release note: none.
Epic: none.

Includes some mechanical code changes from the movement of the category stats from the sstable package into the sstable/block package.

@jbowens jbowens requested review from a team as code owners January 13, 2025 21:11
@jbowens jbowens requested a review from RaduBerinde January 13, 2025 21:11
Copy link

blathers-crl bot commented Jan 13, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens force-pushed the jackson/pebble-master-3748221737d4 branch from 44956a6 to c2e424d Compare January 14, 2025 22:30
@jbowens jbowens requested a review from a team as a code owner January 14, 2025 22:30
@jbowens jbowens requested review from kev-cao and removed request for a team January 14, 2025 22:30
Changes:

 * [`37482217`](cockroachdb/pebble@37482217) sstable/block: add Reader type
 * [`8d3363b3`](cockroachdb/pebble@8d3363b3) sstable/block: move category stats, read env
 * [`a18792eb`](cockroachdb/pebble@a18792eb) sstable: use errorfs in TestIteratorErrorOnInit

Release note: none.
Epic: none.
@jbowens jbowens force-pushed the jackson/pebble-master-3748221737d4 branch from c2e424d to 4c8ee35 Compare January 15, 2025 00:34
@jbowens
Copy link
Collaborator Author

jbowens commented Jan 15, 2025

TFTR

bors r=RaduBerinde

@craig craig bot merged commit 5b7eddf into cockroachdb:master Jan 15, 2025
21 of 22 checks passed
@jbowens jbowens deleted the jackson/pebble-master-3748221737d4 branch January 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants