changefeedccl: rename span-level checkpoint settings for consistency #139064
+54
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `changefeed.frontier_checkpoint_max_bytes` to `changefeed.span_checkpoint.max_bytes` for consistency. Release note: None
|
This change is |
asg0451
reviewed
Jan 14, 2025
andyyang890
force-pushed
the
20250114-span-checkpoint-settings-rename
branch
2 times, most recently
from
be9d128 to
e251780
Compare
andyyang890
force-pushed
the
20250114-span-checkpoint-settings-rename
branch
2 times, most recently
from
049fcc8 to
edfbef8
Compare
asg0451
approved these changes
Jan 14, 2025
This patch renames `changefeed.frontier_checkpoint_frequency` to `changefeed.span_checkpoint.interval` for consistency. Release note: None
…reshold setting This patch renames `changefeed.frontier_highwater_lag_checkpoint_threshold` to `changefeed.span_checkpoint.lag_threshold` for consistency. Release note (ops change): The cluster setting `changefeed.frontier_highwater_lag_checkpoint_threshold` has been renamed to `changefeed.span_checkpoint.lag_threshold`. The old name remains available for backwards-compatibility.
andyyang890
force-pushed
the
20250114-span-checkpoint-settings-rename
branch
from
edfbef8 to
64f47b4
Compare
|
TFTR! bors r=asg0451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits
Epic: CRDB-37337