sql: relax validation for IDENTITY columns #139084
Merged
+61
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thank you for fixing this.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
The validations added in 4f99f9c were too strict. This patch makes it so we can continue having IDENTITY columns that are not backed by a sequence. This can happen if a SERIAL column is created with IDENTITY, and serial_normalization=rowid. Release note (bug fix): Fixed a bug where columns created with GENERATED ... BY IDENTITY with the SERIAL type could incorrectly fail internal validations.
rafiss
force-pushed
the
relax-identity-validation
branch
from
32a8021 to
fbf1492
Compare
|
tftr! bors r+ |
|
Build succeeded: |
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validations added in 4f99f9c were
too strict. This patch makes it so we can continue having IDENTITY
columns that are not backed by a sequence. This can happen if a SERIAL
column is created with IDENTITY, and serial_normalization=rowid.
informs #138925
informs #138972
Release note (bug fix): Fixed a bug where columns created with GENERATED ... BY IDENTITY with the SERIAL type could incorrectly fail internal validations.