internal/metamorphic: fix bugs in KeyFormat abstraction #4266
+185
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
bump |
RaduBerinde
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 18 files reviewed, 1 unresolved discussion (waiting on @jbowens and @sumeerbhola)
metamorphic/testkeys.go line 81 at r1 (raw file):
// returning a new prefix that sorts after the given prefix. func (kg *testkeyKeyGenerator) ExtendPrefix(prefix []byte) []byte { return append(prefix, randBytes(kg.rng, 1, 3)...)
Should we slices.Clip(prefix) here to avoid any unexpected aliasing?
This commit fixes a handful of bugs in the abstraction of the KeyFormat (today only the testkeys KeyFormat exists). It also introduces a --key-format= CLI flag for configuring the key format to use in a particular run of the metamorphic test.
jbowens
force-pushed
the
meta-keyformat
branch
from
fd510eb to
36264d7
Compare
jbowens
commented
Jan 23, 2025
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 18 files reviewed, 1 unresolved discussion (waiting on @RaduBerinde and @sumeerbhola)
metamorphic/testkeys.go line 81 at r1 (raw file):
Previously, RaduBerinde wrote…
Should we
slices.Clip(prefix)here to avoid any unexpected aliasing?
Good idea, done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a handful of bugs in the abstraction of the KeyFormat (today only the testkeys KeyFormat exists). It also introduces a --key-format= CLI flag for configuring the key format to use in a particular run of the metamorphic test.