refactor: move the rpc call top in unsubscribe

codex-storage · Oct 22, 2024 · 3b66799 · 3b66799
1 parent 7b24ffe
commit 3b66799
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ethers/providers/jsonrpc/subscriptions.nim b/ethers/providers/jsonrpc/subscriptions.nim
@@ -218,7 +218,7 @@ method subscribeLogs(subscriptions: PollingSubscriptions,
 method unsubscribe*(subscriptions: PollingSubscriptions,
                    id: JsonNode)
                   {.async.} =
+  discard await subscriptions.client.eth_uninstallFilter(subscriptions.subscriptionMapping[id])
   subscriptions.filters.del(id)
   subscriptions.callbacks.del(id)
-  discard await subscriptions.client.eth_uninstallFilter(subscriptions.subscriptionMapping[id])
   subscriptions.subscriptionMapping.del(id)