Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Symfony ^7.0 #476

Closed
wants to merge 1 commit into from
Closed

Supports Symfony ^7.0 #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
"ext-simplexml": "*",
"aeon-php/calendar": "^1.0",
"coduo/php-to-string": "^3",
"doctrine/lexer": "^1.0||^2.0"
"doctrine/lexer": "^1.0||^2.0||^3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as already mentioned, I would simplify it by allowing only "^3.0"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but as I'm on doctrine orm 3.0 I'm forced to use lexer 3 😅 I'll keep the fork because it's "workish" and I can use it in my project, but i'll remove merge request in your repository, good luck with the fix ! (if ever I have the time I'll look into it)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm but if you remove 1 and 2, it should work for you and I could merge it, no?

Copy link
Author

@tentacode tentacode Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry I haven't read your message properly, lexer 3.0 has a lot of BC Break and the code of phpmatcher don't work with it :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I once tried to upgrade to 3.0 but it wasn't working and I didn't had then enough time to debug why but it seems that it wasn't a bug on my end but rather some changes in the internal behavior of lexer.
I'm gonna close this PR since it can't be merged anyway, sorry

},
"require-dev": {
"ext-pcov": "*",
"phpunit/phpunit": "^10.4",
"openlss/lib-array2xml": "^1.0",
"symfony/expression-language": "^2.3|^3.0|^4.0|^5.0|^6.0",
"symfony/cache": "^2.3|^3.0|^4.0|^5.0|^6.0",
"symfony/var-exporter": "^2.3|^3.0|^4.0|^5.0|^6.0"
"symfony/expression-language": "^2.3|^3.0|^4.0|^5.0|^6.0|^7.0",
"symfony/cache": "^2.3|^3.0|^4.0|^5.0|^6.0|^7.0",
"symfony/var-exporter": "^2.3|^3.0|^4.0|^5.0|^6.0|^7.0"
},
"suggest": {
"openlss/lib-array2xml": "In order ot use Coduo\\PHPMatcher\\Matcher\\XmlMatcher",
Expand Down
213 changes: 49 additions & 164 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading