Automatically populate data properties with passed parameters when onMount() isn't defined #132
Conversation
There was a problem hiding this comment.
@mrigsby Looks good! Would you be up for adding two tests for this commit, one that asserts the MissingOnMount exception and one that asserts that the data properties are actually set? If so, you can run the tests under http://localhost:60299/tests/ and the test needs to be added to test-harness/tests/specs/CBWIRESpec.cfc. You will see numerous examples and it's pretty straightforward integration testing. And if not, no worries, I can add it but it will probably be later this week.
|
Absolutely! Can do. I don't do enough testing... I gotta work on that! |
|
I created a few tests, more than two. In the process of testing I figured out that isStruct() returns true for a CFML component so I added the check for isObject() as well as isCustomFunction() while I was at it. |
grantcopley
changed the title
grantcopley
merged commit 26a9332
into
coldbox-modules:development
|
@grantcopley No problem at all. Thank you for all your hard work on cbwire, it's great. Glad I can contribute. |
|
@mrigsby Released in CBWIRE 3.2. https://www.ortussolutions.com/blog/cbwire-32-released Thank you for your contributions! |
Building on box products' love of conventions, if onMount() does not exist, we check that each parameter is a string, boolean, numeric, date, array, or struct and if they are we populate the component using scope population instead of setters.
#131