Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala 2.12.19 and 2.13.13 #1421

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Add support for Scala 2.12.19 and 2.13.13 #1421

merged 4 commits into from
Mar 5, 2024

Conversation

lefou
Copy link
Member

@lefou lefou commented Feb 21, 2024

@lefou lefou changed the title Added support for Scala 2.12.19 Add support for Scala 2.12.19 Feb 21, 2024
@lefou lefou changed the title Add support for Scala 2.12.19 Add support for Scala 2.12.19 and 2.13.13 Feb 22, 2024
@lefou lefou force-pushed the update-scala-2.12.19 branch from 2ef71cf to f682525 Compare February 22, 2024 09:03
@lefou
Copy link
Member Author

lefou commented Feb 28, 2024

Looks like it's only the Ammonite BSP server tests, which are failing now. Any help would be appreciated.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 28, 2024

Maybe the server needs to be updated first?

@lefou lefou force-pushed the update-scala-2.12.19 branch from 9a979b0 to 46f3af6 Compare March 1, 2024 08:30
@lefou
Copy link
Member Author

lefou commented Mar 2, 2024

@alexarchambault Any idea why the BSP server is failing for Scala 2.13.13, but not for 2.13.12? There is no obvious error message. Since you contributed the BSP server code, maybe you have an idea or can help out?

@lefou
Copy link
Member Author

lefou commented Mar 4, 2024

Looks like the BSP server tests fail for many more Scala versions, we just don't run these tests in CI. I saw them fail here: #1436

It's probably OK to ignore them for now, since they already broken, but users haven't reported any issues about that. So releasing for latest Scala versions is IMHO better that holding back for some minor issues.

@lefou
Copy link
Member Author

lefou commented Mar 4, 2024

I handled the failing tests in PR #1436, since we see the same issues on older Scala versions.

@lefou lefou merged commit 95b58dc into main Mar 5, 2024
25 checks passed
@lefou lefou deleted the update-scala-2.12.19 branch March 5, 2024 11:26
@lefou lefou added this to the 3.0.0-M1 milestone Mar 5, 2024
@panbingkun panbingkun mentioned this pull request Apr 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please publish for Scala 2.12.19 and 2.13.13
2 participants