-
-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Scala 2.12.19 and 2.13.13 #1421
Conversation
2ef71cf
to
f682525
Compare
Looks like it's only the Ammonite BSP server tests, which are failing now. Any help would be appreciated. |
Maybe the server needs to be updated first? |
9a979b0
to
46f3af6
Compare
@alexarchambault Any idea why the BSP server is failing for Scala 2.13.13, but not for 2.13.12? There is no obvious error message. Since you contributed the BSP server code, maybe you have an idea or can help out? |
Looks like the BSP server tests fail for many more Scala versions, we just don't run these tests in CI. I saw them fail here: #1436 It's probably OK to ignore them for now, since they already broken, but users haven't reported any issues about that. So releasing for latest Scala versions is IMHO better that holding back for some minor issues. |
I handled the failing tests in PR #1436, since we see the same issues on older Scala versions. |
Depends on
Fix #1420