Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .local integration tests in windows CI #4299

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 13, 2025

  • Need to move from temurin:17 to zulu:17 to get things working on my windows-arm laptop (temurin did not back-publish older JVMs for windows-arm)

  • Get rid of the custom pathingJar we defined in dist/package.mill (using custom path rendering) which doesn't seem to work, in exchange for the default Jvm.createClasspathPassingJar (using path-as-url rendering) that does seem to work

  • Make def launcher make use of runUseArgsFile similarly to the various run tasks

  • Make the integration tests use the ./mill.bat launcher on windows, rather than ./mill as a shell script, as the shell script doesn't seem to work properly when used in a windows environment

@lihaoyi lihaoyi added the run-all-tests Disables selective test execution on this pR and just runs all tests label Jan 13, 2025
@lihaoyi lihaoyi marked this pull request as ready for review January 13, 2025 05:58
@lihaoyi lihaoyi merged commit 570a262 into com-lihaoyi:main Jan 13, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-all-tests Disables selective test execution on this pR and just runs all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant