<1s(?) build time #1602
Open
<1s(?) build time #1602
+58
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
MikeBusuttil
commented
Dec 29, 2024
Comment on lines
+20
to
+21
| RE2 val_regexp(R"(VAL_ (\w+) (\w+) (.*))"); | ||
| RE2 val_split_regexp(R"((([0-9]) \"(.+?)\"))"); |
There was a problem hiding this comment.
Notes:
- no tests match
\s*[-+]?so this was removed - RE2 doesn't support a variable number of matching groups (the reason for the small refactor here and below)
Open
|
This does improve the speed, but doesn't quite get to <1s. Ran a bunch of times on my machine, and it's consistently ~2.2s: Aside from that, this approach adds both a fairly large dependency and goes from 1 -> 2 cases.
I'm not sold that we can't do this with minimal to no tradeoffs (such as having to check in a precompiled header when the regex changes). |
† Note: 0.9(5)s means 0.9s ± 0.05s which means between 0.85 and 0.95 seconds. 0.95(1) means between 0.949...0.951 |
|
Update @adeebshihadeh :
|
Co-authored-by: William Deegan <[email protected]>
|
Yo @adeebshihadeh can you run this again and let me know how fast it is on your machine? I trimmed an additional 25% off the runtime with a SConstruct optimization (that might be worth implementing in other repos you guys maintain) |
Co-authored-by: William Deegan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAST=1)This should resolve issues #1180 and #1528 by reporting <1s build time when running
Results:
Thanks to: