Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow brake hold #34384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow brake hold #34384

wants to merge 1 commit into from
+5 −2

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jan 15, 2025 •
edited
Loading

Closes #33988

Check:

@sshane sshane added enhancement car vehicle-specific labels Jan 15, 2025
@jyoung8607
Copy link
Collaborator

At present, VW doesn't set brakeHoldActive at all, so your proposed change doesn't affect us.

For the future, I'm actually not sure what happens if the driver tries to engage while in auto hold. Unfortunately my Golf R is stored for the winter and my Tiguan doesn't have auto hold. I'll ask for a tester in #volkswagen.

leonunix pushed a commit to leonunix/openpilot that referenced this pull request Jan 15, 2025
test commaai#34384
161ac7c
jsegill
jsegill approved these changes Jan 15, 2025
View reviewed changes
Copy link

@jsegill jsegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it work for Toyota! Looks like it took removing a line from my PR. Wish I caught that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsegill jsegill jsegill approved these changes

Assignees
No one assigned
Labels
car vehicle-specific enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to activate OP while brake hold active
3 participants
@sshane @jyoung8607 @jsegill