Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight code refactor in "Skills" page #123

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Conversation

softy-dev
Copy link
Contributor

This PR:

  • Removes a part of the code that deals with quests (since it is now in the Farmer page, I presume it is no longer needed here);
  • Adds a comment;
  • Changes the AccordionTrigger's text content from "Skill Achievements" to "Skills", following the project's apparent rule of naming them according to whether the section tracks only achievements or not (in the case of Skills, it also tracks the skills themselves, not just the achievements; a similar example is the "Stardrops" section).

- Changes the AccordionTrigger's text content from
"Skill Achievements" to "Skills", following the
project's apparent rule of naming according to
whether the section tracks only achievements or
not (in the case of Skills, it also tracks the
skills themselves, not just the achievements; a
similar example is the "Stardrops" section).
Copy link

vercel bot commented Nov 29, 2024

@nekosoffy is attempting to deploy a commit to the stardew Team on Vercel.

A member of the Team first needs to authorize it.

@softy-dev softy-dev changed the title Refactor of "Skills" page code Slight code refactor in "Skills" page Nov 29, 2024
@clxmente
Copy link
Member

awesome thx

@clxmente clxmente merged commit 95e6686 into communitycenter:main Nov 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants