Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4848 #32

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Fix 4848 #32

merged 6 commits into from
Oct 23, 2024

Conversation

partouf
Copy link
Member

@partouf partouf commented Mar 11, 2023

Aiming to fix compiler-explorer/compiler-explorer#4848

Issue is: function starts with library file

Discussed before elsewhere, but to really fix this we must:

  • Move the library filter to a post-process step
  • Only eliminate the function that has no usercode at all, otherwise leave it

@OfekShilon
Copy link
Member

Not sure what the fix was supposed to do. The problem (the rdtsc drop) persists even when checking off the library filter.

@partouf
Copy link
Member Author

partouf commented Nov 10, 2023

  • Only eliminate the function that has no usercode at all, otherwise leave it

Correct, but the part that wasn't implemented here was the 2nd bulletpoint Only eliminate the function that has no usercode at all, otherwise leave it

@partouf
Copy link
Member Author

partouf commented Nov 10, 2023

(And it had a bug where libcode was sometimes always filtered it without looking at the filter setting)

@partouf
Copy link
Member Author

partouf commented Nov 10, 2023

But am extremely fuzzy on the details, i shouldve continued this pr when i understood what was going on

@partouf partouf marked this pull request as ready for review October 23, 2024 20:39
@partouf partouf changed the title [WIP] Fix 4848 Fix 4848 Oct 23, 2024
@partouf partouf merged commit 3979926 into main Oct 23, 2024
1 check passed
@partouf partouf deleted the fix-4848 branch October 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Assembly output is incorrect for a compiled binary affecting gcc versions 11.2 - 12.2 for x84_64
2 participants