Remove the use of Dirent.path as deprecated #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9078768387Details
💛 - Coveralls |
|
Released as 4.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some weird errors with certain Node versions, where the
pathon aDirentwas pointing at either the parent path or the path of the entry itself, in a really inconsistent way. It turns out that thepathentry has been deprecated, but it is still offered in the autocompletion for some reason, whereas the replacement is not.The simple solution is to remove its use, because the query loader can use the supplied path as the base for joining.
This should help get comunica/comunica#1340 pass the CI on Node 18.