Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to result entry naming for tooling compatibility #8

Merged
merged 5 commits into from
May 8, 2024
Merged

Revert changes to result entry naming for tooling compatibility #8

merged 5 commits into from
May 8, 2024

Conversation

surilindur
Copy link
Contributor

Here is the requested set of changes to revert the result entry names to how they were in version 2.x to maintain compatibility with scripts that process them. The time (previously duration) and results (previously resultCount) are now back again, and the corresponding Max and Min entries have also been renamed. The resultHash column has been changed to hash, as well, because it was resultHash to align it with resultCount but that is gone now.

The readme example now includes the full set of columns produced when running against a Comunica SPARQL endpoint that provides the httpRequests metadata, if you want to see exactly what it outputs. Hopefully this works better now with all the scripts. 🙂

@coveralls
Copy link

coveralls commented May 8, 2024

Pull Request Test Coverage Report for Build 8999919866

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8894231204: 0.0%
Covered Lines: 241
Relevant Lines: 241

💛 - Coveralls

@rubensworks rubensworks merged commit 19fe017 into comunica:master May 8, 2024
6 checks passed
@rubensworks
Copy link
Member

Thanks! Released as 4.0.0.

@surilindur surilindur deleted the fix/result-entry-naming branch May 8, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants