Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO / FIXME review #526

Merged
merged 3 commits into from
Sep 19, 2022
Merged

TODO / FIXME review #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c13618a
Add close TC issue reference
maurolacy Aug 25, 2022
c16b6f9
Remove outdated TODO
maurolacy Sep 19, 2022
2cccfbd
Remove outdated TODOs
maurolacy Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion contracts/tgrade-ap-voting/src/msg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ pub struct InstantiateMsg {
pub multisig_code_id: u64,
}

// TODO: add some T variants? Maybe good enough as fixed Empty for now
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)]
#[serde(rename_all = "snake_case")]
pub enum ExecuteMsg {
Expand Down
1 change: 0 additions & 1 deletion contracts/tgrade-oc-proposals/src/msg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ pub struct InstantiateMsg {
pub valset_addr: String,
}

// TODO: add some T variants? Maybe good enough as fixed Empty for now
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)]
#[serde(rename_all = "snake_case")]
pub enum ExecuteMsg {
Expand Down
2 changes: 1 addition & 1 deletion contracts/tgrade-trusted-circle/src/contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ pub fn execute_leave_trusted_circle<Q: CustomQuery>(
) -> Result<Response, ContractError> {
cw_utils::nonpayable(&info)?;

// FIXME: special check if last member leaving (future story)
// FIXME: Special check if last member leaving (https://github.com/confio/tgrade-contracts/issues/521)
let escrow = ESCROWS
.may_load(deps.storage, &info.sender)?
.ok_or(ContractError::NotAMember {})?;
Expand Down
1 change: 0 additions & 1 deletion contracts/tgrade-trusted-circle/src/msg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ pub enum ExecuteMsg {
WithdrawRewards {},
}

// TODO: expose batch query
#[derive(Serialize, Deserialize, Clone, PartialEq, JsonSchema, Debug)]
#[serde(rename_all = "snake_case")]
pub enum QueryMsg {
Expand Down
2 changes: 1 addition & 1 deletion contracts/tgrade-trusted-circle/src/tests/bdd_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ fn voting_deposit_return_propose_leave() {
// can leave, but long_leave
leave(deps.as_mut(), VOTING).unwrap();

// TODO: we need to handle close TRUSTED_CIRCLE here (last voter leaving)
// TODO: We need to handle close TRUSTED_CIRCLE here (last voter leaving) (https://github.com/confio/tgrade-contracts/issues/521)
// check no longer voting
assert_membership(deps.as_ref(), VOTING, Some(0));
assert_eq!(query_total_points(deps.as_ref()).unwrap().points, 0);
Expand Down