Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Should be able to control if
INTERNAL
version is used for requests whenkey.ignore
is set to false. The general scenario is duplicate records being indexed and the worst case scenario is out-of-order messages being indexed which is not as likely.See #499 (comment)
Solution
Created
version.ignore
config.true ->
INTERNAL
false ->
EXTERNAL
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing if INTERNAL version is used for
version.ignore
set to true and also check if any error is thrown with duplicate messages.Testing done:
Release Plan
This feature is backwards compatible.
Merging to master
Rolling back might result in validation error for people that use
version.ignore