Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version Type & Field Configuration #639

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jokefaker
Copy link

@jokefaker jokefaker commented Jun 22, 2022

Problem

  • Not able to custom version type
  • Not able to set custom version when use external version type

Solution

  • add version.type configuration: internal, external, external_gte
  • add version.field configuration to support read version value from payload
  • use version.type and version.field in data convert
Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing if version.type and version.type.field is set, and check if IndexRequest is correct

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

This feature is backwards compatible.
Merging to master
Rolling back might result in validation error for people that use version.type or version.type.field

@jokefaker jokefaker requested a review from a team as a code owner June 22, 2022 06:28
@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@blackmad
Copy link

is there a possibility of this being merged?

@jokefaker jokefaker requested a review from a team as a code owner August 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants