Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump connectrpc.com/conformance from 1.0.0-rc3 to 1.0.0-rc4 in /internal/conformance #717

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 25, 2024

Bumps connectrpc.com/conformance from 1.0.0-rc3 to 1.0.0-rc4.

Release notes

Sourced from connectrpc.com/conformance's releases.

v1.0.0-rc4

This contains some minor compatibility issues with the previous release candidate:

  1. The message previously known as connectrpc.conformance.v1.ClientCompatRequest.TLSCreds has been moved to a top-level message and is now named connectrpc.conformance.v1.TLSCreds. This will impact generated code and user code that refers to it.
  2. Some test cases have been moved around and renamed, so patterns in older "known-failing" and "known-flaky" configurations may no longer be valid.

What's Changed

Bugfixes

  • In referenceclient, inspecting wire details needs to support compressed error bodies by @​jhump in #811
  • Prevent errant 'content-length: 0' request header from being printed when --trace used by @​jhump in #815
  • Fix deflate algorithm to adhere to RFC 1950 by @​jchadwick-buf in connectrpc/conformance#824
  • Fix naming and filtering of test cases that use the gRPC implementations by @​jhump in #814
  • Troubleshoot and fix issues in grpc-web JS conformance client by @​jhump in #831
  • Server response must include a certificate when using TLS by @​jhump in #832
  • Fix issues with test runner hanging by @​jhump in #829
  • Relax expectation for unspecified errors, fix expectation for cardinality violations by @​jhump in #833

Enhancements

  • Tighten up when responses are allowed to combine headers and trailers; add check for number of unsent requests by @​jhump in #805
  • Add support for --trace flag for test cases that use the gRPC implementations by @​jhump in #823
  • Test runner generates self-signed cert that servers-under-test can use by @​jhump in #828
  • Reconcile test cases with latest Connect spec changes and pull in fixes from latest connect-go release (v1.16.0) by @​jhump in #826

Other Changes

  • Add docs for configuring and running tests, testing servers, and testing clients by @​jhump and @​smaye81 in #804, #808, #818, and #819
  • Add GitHub action workflow to automatically build/publish release artifacts after tag is created by @​jhump in #835

Full Changelog: connectrpc/conformance@v1.0.0-rc3...v1.0.0-rc4

Changelog

Sourced from connectrpc.com/conformance's changelog.

Releasing the Conformance Suite

The conformance repository has a release workflow which publishes the test runner binary, connectconformance, as an artifact that is part of the GitHub release. But it does still require a commit to update the version number in code, and then manually curating the release notes.

  1. Clone the repo, ensuring you have the latest main.

  2. On a new branch, open https://github.com/connectrpc/conformance/blob/main/internal/version.go and change the buildVersion constant to an appropriate semantic version. To select the correct version, look at the version number of the [latest release] and the changes that are included in this new release.

    -const Version = "1.0.0-rc4-dev"
    +const Version = "1.0.0-rc4"

    This usually entails just removing the "dev" version, but if only a patch release release is warranted, but the "dev" version implied a minor version, then set the minor version back, for example 1.1.0-dev -> 1.0.1. If a release candidate is warranted, use an appropriate suffix.

  3. Open a PR titled "Prepare for vX.Y.Z" ([Example PR #801](connectrpc/conformance#801)) and a description, tagging at least one current maintainer. Once it's reviewed and CI passes, merge it.

    Make sure no new commits are merged until the release is complete.

  4. Using the Github UI, create a new release like so:

    • Under “Choose a tag”, type in “vX.Y.Z” to create a new tag for the release upon publish. Note: The release job does infer the version from the release string and expects versions to start with v (e.g. v0.1.0).
    • Target the main branch.
    • Title the Release the same as the tag: “vX.Y.Z”.
    • Click “Set as latest release”.
    • If this is a release candidate, or any other kind of pre-release, click "Set as a pre-release". A pre-v1.0.0 number, like "v0.3.0", should not be marked as a pre-release.
    • Set the last version as the “Previous tag”.
    • Click “Generate release notes” to autogenerate release notes.
    • Edit the release notes.
      • Tweak the change description for each if necessary so it summarizes the salient aspect(s) of the change in a single sentence. Detail is not needed as a user could follow the link to the relevant PR. (Potentially take a pass at PR descriptions and revise to increase clarity for users that visit the PRs from the release notes.)
      • Related commits can be grouped together with a single entry that has links to all relevant PRs (and attributes all relevant contributors).
      • A summary may be added if warranted.
      • The items in the list should be broken up into sub-categories. The typical sub-categories to use follow:

... (truncated)

Commits
  • 7d7bb3c Prepare for v1.0.0-rc4 (#836)
  • ea10956 Reconcile test cases w/ latest spec changes and fixes from latest connect-go ...
  • f92ce2d Add GitHub action workflow to build/publish artifacts after release is create...
  • e305a3c Bump golang.org/x/net from 0.21.0 to 0.22.0 (#822)
  • eb026da Bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#821)
  • a66401d Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#820)
  • 3f31e07 Relax expectation for unspecified errors, fix expectation for cardinality vio...
  • 109380c Fix issues with test runner hanging (#829)
  • caa2708 Server response must include a certificate when using TLS (#832)
  • c57e886 Test runner generates self-signed cert that servers-under-test can use (#828)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [connectrpc.com/conformance](https://github.com/connectrpc/conformance) from 1.0.0-rc3 to 1.0.0-rc4.
- [Release notes](https://github.com/connectrpc/conformance/releases)
- [Changelog](https://github.com/connectrpc/conformance/blob/main/RELEASE.md)
- [Commits](connectrpc/conformance@v1.0.0-rc3...v1.0.0-rc4)

---
updated-dependencies:
- dependency-name: connectrpc.com/conformance
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 25, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 29, 2024

Looks like connectrpc.com/conformance is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Mar 29, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/internal/conformance/connectrpc.com/conformance-1.0.0-rc4 branch March 29, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants