Fix protoc-gen-connect-go schema variable case handling #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/fixGenServiceVars
branch
from
35bdcd8 to
340b9e0
Compare
akshayjshah
approved these changes
Jan 8, 2025
jhump
approved these changes
Jan 8, 2025
Merged
emcfarlane
changed the title
emcfarlane
added a commit
that referenced
this pull request
Jan 8, 2025
Below are the draft notes for the release, this is a patch release to fix the protoc-gen-connect-go issue: ---- # v1.18.1 ## What's Changed ### Bugfixes * Fix protoc-gen-connect-go schema variable case handling by @emcfarlane in #808 **Full Changelog**: v1.18.0...v1.18.1 Signed-off-by: Edward McFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of various casing for protoc-gen-connect-go when generating the service methods variable.
Fixes #807