Remove DDF feature repos temporarily #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blen-desta
approved these changes
Jun 17, 2019
peterhuffer
approved these changes
Jun 17, 2019
| <repository>mvn:ddf.features/admin/${ddf.version}/xml/features</repository> | ||
| <repository>mvn:ddf.features/security/${ddf.version}/xml/features</repository> | ||
| <repository>mvn:ddf.catalog/catalog-app/${ddf.version}/xml/features</repository> | ||
| <!-- Uncomment and put in version ranges once https://github.com/connexta/admin-console/issues/246 is complete. --> |
There was a problem hiding this comment.
❓ How does the features still being used in the commented out feature files get found by this feature file?
❓ Should we add TODO to all these comments to make them easily searchable?
There was a problem hiding this comment.
I can add the TODO. The features files will need to be already included in the running Karaf instance in order for these features to be installed (this is the way the 1.2.x branch of admin-console works).
brjeter
force-pushed
the
removeFeatureRepos
branch
from
4bd5d30 to
fb02cc7
Compare
|
build now |
brjeter
force-pushed
the
removeFeatureRepos
branch
from
fb02cc7 to
da1c580
Compare
|
Tested per the instruction. Ingested a files, search for it successfully. |
ahoffer
approved these changes
Jun 17, 2019
|
build now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes DDF feature repos and disables the feature itests until we can upgrade Karaf. See #246 for details.
Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@peterhuffer @blen-desta
How should this be tested? (List steps with links to updated documentation)
CI
Hero steps:
1.3.1-SNAPSHOTand ddf version2.16.0-SNAPSHOTlist -t 0 -s | grep -i ddfevery once in awhile, and make sure no2.15.0versioned DDF bundles are starting up.Any background context you want to provide?
Screenshots (if appropriate)
Checklist: