Fixes: Annotations in Traits are ignored #240

[ribeirobreno]

Reverts PR #237 to fix issue #240
This bug fix will be compatible with other versions of 4.3.*.

[greg-1-anderson]

We'd like to be able to turn on the new behavior via a static class method that sets a protected static boolean. We'll default the boolean to "no trait optimization" in 4.x, default it to "with trait optimization" in 5.x (main), and in the future consider whether commands in traits is something we want to continue to support going forward.

[codecov]

Codecov Report

Merging #241 (8b4d9c0) into main (f703102) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #241      +/-   ##
============================================
- Coverage     89.77%   89.76%   -0.01%     
+ Complexity      733      731       -2     
============================================
  Files            45       45              
  Lines          1897     1896       -1     
============================================
- Hits           1703     1702       -1     
  Misses          194      194              

Impacted Files	Coverage Δ
src/AnnotatedCommandFactory.php	96.35% <100.00%> (-0.02%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f703102...8b4d9c0. Read the comment docs.

[weitzman]

I would prefer to default to optimized in 4.4 (minor version). Use the flag to satisfy folks that must use traits and must upgrade.

[greg-1-anderson]

I think it's easier for an app like Drush to turn the flag on than for Robo scripts to have to turn it off to maintain b/c

[greg-1-anderson]

Because I already merged changed for 4.4.0 onto the 4.x branch, I released 4.3.3 as a branch off of the 4.3.2.