Fixes #65: Allow commands to call other commands

[grasmash]

No description provided.

[grasmash]

This introduces the new @calls tag, but does not actually do anything with it yet.

[greg-1-anderson]

Maybe array-merge these together, so folks can use multiple @calls in addition to csv, if they prefer?

[grasmash]

Yes I'd prefer that. I briefly attempted this but wasn't quite sure how to access multiple @calls values, each usage appeared to overwrite the previous.

[greg-1-anderson]

This is the interesting part. The $application field of Symfony Console's command class is private. 😢

We could override setApplication to cache our own copy of it. Not super great.

[grasmash]

Is there a logging mechanism available?

[grasmash]

@greg-1-anderson Let's make a list of what it will take to merge this in.

• Allow multiple @Calls annotations to be used
• Allow argument values to be passed via @Calls annotations
• Move executeCallsCommands() logic to ... somewhere else. @greg-1-anderson You briefly mentioned a specific idea for how to better implement this, can you elaborate?

[greg-1-anderson]

If there are multiple @Calls annotations, this function will be called multiple times. Currently, this implementation overwrites via setCalls(). It could also call getCalls() first and merge. Might want to move where the csv is converted to an array here, maybe.

[greg-1-anderson]

I have reservations about Allow argument values to be passed via @calls annotations. Once we are calling other commands with annotations, then we need parameters, then we need to process substitutions on the parameters, then maybe we need to call a function to get the substitution values. Annotations shouldn't become their own way to write code.

I tend to think that this implementation should be abandoned, and we should make it easier for one command to call another via PHP.

[grasmash]

@greg-1-anderson I'm ok with abandoning this implementation and following up with a different plan in #64.

I mostly want to avoid:

<?php

  /**
   * @command tests:all
   */
  public function testsAll() {
    $result = $invoker->invoke('tests:behat');
    if (!$result) {
      return 1;
    }
    $result = $invoker->invoke('tests:phpunit');
    if (!$result) {
      return 1;
    }
    $result = $invoker->invoke('tests:custom');
    if (!$result) {
      return 1;
    }
  }