Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov changes! #37

Closed
wants to merge 1 commit into from

Conversation

thomasrockhu
Copy link

#36

@greg-1-anderson
Copy link
Member

Thanks @thomasrockhu, I really appreciate it. From this I learned that @codecov integration is working fine for external contributors, and I also learned that a report isn't posted if there are no significant changes to the code base.

Very helpful -- thanks for the PR!

@greg-1-anderson
Copy link
Member

OK if I did not miss anything it seems that the bash script + installing the app will == success, and it was the lack of the app here, not the lack of changes that caused the comments not to appear.

Going to try re-running the same test and see if it works w/out other changes.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #37 (a51f36a) into main (d39ffe7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #37   +/-   ##
=========================================
  Coverage     86.73%   86.73%           
  Complexity      165      165           
=========================================
  Files            15       15           
  Lines           377      377           
=========================================
  Hits            327      327           
  Misses           50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39ffe7...a51f36a. Read the comment docs.

@greg-1-anderson
Copy link
Member

Ah, cool, we have achieved comments from forked pull requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants