Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds process for zero touch registration and functionality to update processes and configs #64
Adds process for zero touch registration and functionality to update processes and configs #64
Changes from all commits
b0304ff
8a5ba11
c291e6a
fe299f8
b6b5dea
91222d4
09419ce
c60f7a4
18b5633
dec1ba0
ef0d82a
74fc4b9
3d0e209
6e54a14
8904e99
d14af7e
7254c1b
d111454
222c666
d2180bf
97f8b01
949c60c
1b6b45c
8624668
771a6e3
a08405d
0dc1160
f754085
abb1a3e
a641df3
2f11137
17f8ffa
c194bb0
86430aa
2daa2eb
6574d77
24bd517
872a8fd
a656219
1e8dc43
b950c1c
2aa1a46
5ca08c7
e578bd4
47bdb9c
2604c00
7062d10
9c6d293
9ccd683
80f59a3
9782e7e
fc24959
b9aa9c8
a6e0e10
20578ff
a969873
a3a4233
af01828
13cd2ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for errors immediately after marshalling to prevent using invalid data
The error returned by
toml.Marshal
should be checked immediately before using thedata
variable to prevent potential issues if the marshalling fails.Apply this diff to fix the issue:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Properly annotate deprecated field
PluginDir
.The
PluginDir
field is marked as deprecated, but the deprecation notice should follow Go conventions. The comment should start with "Deprecated:" and be placed immediately before the field declaration. This improves readability and alerts developers to avoid using deprecated fields.Apply this diff to adjust the deprecation comment:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Inconsistent TOML tag casing for
BinaryName
.The TOML tag
BinaryName
uses camel case, whereas other TOML tags use snake case (e.g.,runtime_type
,default_runtime_name
). For consistency and to follow standard naming conventions, consider changing the TOML tag tobinary_name
.Apply this diff to correct the TOML tag: