feat: support for selection and match algorithms #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: we currently have an interface to selection but not match algorithms Solution: improve the algorithm interface by removing the match logic from the graph, and creating an interface that the graph uses. In practice I wanted to use this when I realized I needed a new match algorithm to match in a range of strings. Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
add-range-algorithm
branch
from
deafd56 to
9d2fef1
Compare
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we currently have an interface to selection but not match algorithms Solution: improve the algorithm interface by removing the match logic from the graph, and creating an interface that the graph uses. In practice I wanted to use this when I realized I needed a new match algorithm to match in a range of strings.