wip: add constraint select algorithm #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: we need to be able to have more complex selection logic Solution: prototype constraint selection algorithm Signed-off-by: vsoch <[email protected]>
Problem: a constraint needs to be able to run arbitrary filters Solution: implement the constraint->step->filter step! Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Problem: we need to be able to select a different selection algorithm on job submit, because one might require variables that are not present. Solution: add the selection_algorithm to the submit job endpoint. Signed-off-by: vsoch <[email protected]>
Problem: most people will want to match a combination of range and equality. They should be under one place. Solution: update the match algorithm to be a superset of two algorithms specific to this, range and equals. It really sucks without power, sad dinosaur :( Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a PR over the next several days (pending on when I get power back, I'm tethered to my work phone sitting in my car to open this 😭 ) that has what we need for the next round of experiments. Specifically:
Our ETA on power is tomorrow, and that's the earliest, so I'm probably going to focus on staying alive for the next few days, but it's not that bad to sit in the car and do bits of work. It still kind of sucks though. 😢
I do have cool experiments underway, just 5x slower than I would have been with power, will hopefully be able to get them done and shared soon.
insert Monty Python I'm not dead yet