Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Convert all remaining except Apollo tests to Jasmine #386

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

monotkate
Copy link
Contributor

@monotkate monotkate commented Oct 20, 2018

WhatDo!?

Convert most of the remaining unit tests to Jasmine.

Basic transitions:

  • to.eq-> toBe
  • to.be.false -> toBeFalsy
  • to.be.null -> toBeNull
  • to.deep.eq -> toEqual
  • to.have.deep.members -> toEqual(expect.arrayContaining())
  • to.have.members -> toEqual(expect.arrayContaining())
  • to.throw -> toThrow

New (most of these are tricky, double check me on them 😕 )

  • to.include -> toContain
  • to.deep.include -> to.Equal(expect.objectContaining())
  • expect().to.not.include.all.keys -> expect(Object.keys()).not.toEqual(expect.arrayContaining())

@monotkate monotkate requested a review from nevir October 20, 2018 23:24
@monotkate monotkate changed the base branch from miranda/moar-jasmine to master November 4, 2018 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant