Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves: GitHub handling, AppServiceProvider and 500 error message rendering #4754

Open
wants to merge 22 commits into
base: next
Choose a base branch
from

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Jan 6, 2025

Changes

  • feat: Added Purify for better HTML sanitization
  • fix: render html on 500 error pages correctly

github.php:

  • fix: GitHub JWT token timing issue (more information about this issues here Expiration time' claim ('exp') is too far in the future probot/probot#1426).
    • issuedAt -1min -> this is to avoid token not yet valid issues
    • expiresAt +8min -> this is to make sure the token is not valid longer then 10 min (to avoid the issue described in the linked issue) as tokens have to have a lifespan of less then 10min, this should help with time differences of less then about 1min (most cases) - as the total valid time is 9min (with the -1min) -> for any case of over 50s time out of sync (System vs GitHub API time) it will throw an error.
  • fix: Expiration time' claim ('exp') must be a numeric value
  • refactor: rename functions to make code more clear
  • refactor: use camel case on functions consistently
  • refactor: consolidate code
  • refactor: better error handling in github.php and GithubAppPermissionJob.php

AppServiceProvider.php:

  • feat: Configure commands for production
  • feat: Configure modals for better error handling
  • chore: remove unused authentik stuff
  • refactor: move things to separate functions
  • refactor: improve password security by not allowing compromised passwords

Issues

- Remove unused authentik stuff
- Move things to separate functions
- Configure commands for production
- Configure modals for better error handling
- Improve password security by not allowing compromised passwords.
- Rename some things to make it clearer.
- Sort imports
- Rename functions
- Consolidate Code
- Fix: timing issues with JWT tokens
- Clearer error handling
@peaklabs-dev peaklabs-dev added the 🏔️ Peaklabs A label for PRs from Peaklabs. label Jan 6, 2025
@peaklabs-dev peaklabs-dev changed the title Improves: GitHub handling and AppServiceProvider Improves: GitHub handling, AppServiceProvider and 500 error message rendering Jan 6, 2025
@peaklabs-dev peaklabs-dev marked this pull request as ready for review January 6, 2025 17:34
@peaklabs-dev peaklabs-dev marked this pull request as draft January 6, 2025 17:40
@peaklabs-dev peaklabs-dev marked this pull request as ready for review January 6, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏔️ Peaklabs A label for PRs from Peaklabs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant