-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves: GitHub handling, AppServiceProvider and 500 error message rendering #4754
Open
peaklabs-dev
wants to merge
22
commits into
next
Choose a base branch
from
improve-git-and-service-provider
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused authentik stuff - Move things to separate functions - Configure commands for production - Configure modals for better error handling - Improve password security by not allowing compromised passwords. - Rename some things to make it clearer. - Sort imports
- Rename functions - Consolidate Code - Fix: timing issues with JWT tokens - Clearer error handling
peaklabs-dev
changed the title
Improves: GitHub handling and AppServiceProvider
Improves: GitHub handling, AppServiceProvider and 500 error message rendering
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
github.php
:issuedAt -1min
-> this is to avoid token not yet valid issuesexpiresAt +8min
-> this is to make sure the token is not valid longer then 10 min (to avoid the issue described in the linked issue) as tokens have to have a lifespan of less then 10min, this should help with time differences of less then about 1min (most cases) - as the total valid time is 9min (with the -1min) -> for any case of over 50s time out of sync (System vs GitHub API time) it will throw an error.Expiration time' claim ('exp') must be a numeric value
github.php
andGithubAppPermissionJob.php
AppServiceProvider.php
:Issues