-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impove Onboarding / Membership management process #771
base: develop
Are you sure you want to change the base?
Conversation
…e in new_petition email subject
… in the organization list)
@sseerrggii I'm still polishing some details and working in some points, but I'm unable to reproduce the 1st issue 🤔:
Do you have more specific information about those problems? |
@franpb14 Do you want to take a quick look and give me your feedback? CI is failing due to:
Maybe something changed in GH Actions 🤔 and now we need to manually install the ImageMagick library? |
@@ -6,6 +6,8 @@ def destroy | |||
toggle_active_posts | |||
@member.destroy | |||
|
|||
OrganizationNotifier.member_deleted(@member).deliver_now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why deliver_now
instead of deliver_later
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! I just copy-pasted the same workflow we are already using for emails, but I think this is probably something from the past. I'll move all email delivery to the background queues.
No problem, we will test whole process |
Hello team! Thank you very much for the updates! I've been testing some of the features and I’m posting my feedback after each item of the list.
Feedback: I registered as new user and the message reminding me to join a timebank appeared in 3 occasions. Before (https://staging.deploy.timeoverflow.org/members/please_confirm) and after (https://staging.deploy.timeoverflow.org/organizations) confirming the email. Then I logged out and in again and it also appeared upon requesting to join a timebank. I would suggest keeping it only after the email confirmation and if possible send a reminder email within 15 days. And could you please review the text to make the process a bit clearer? Suggestion: Your registration will be completed once you have requested to join a timebank and the timebank accepts your request. If you do not request to join a timebank within 30 days, your user will be automatically deleted from the system.
Feedback: It works!
Feedback/query: This is not yet in production, right? In Sants we still see the duplicates.
Feedback: It works both during the registration process and when I logged out and logged in again.
Feedback: OK! And if you consider improving the email that the admins receive, I have a suggestion for the text: “Hello, XXX has just requested to join xxx Timebank. You can enter …. to accept or reject the request. Once you accept the request the user will automatically appear on your users list.”
Feedback: I couldn’t test this but it’s a great feature!
Feedback: ok. Bonus track: |
@Mariaadbdt thank you for your feedback! I'm going to address those points in the following days. |
Thanks @Mariaadbdt for testing and feedback This features are not in production, when we approve all the changes @markets will create a new release of TimeOverflow on production About the suggestion "If you do not request to join a timebank within 30 days, your user will be automatically deleted from the system." In order to no add complexity to this development I will keep this work in manual work of ADBdT (super admin) |
@Mariaadbdt @sseerrggii Note about this point:
The new code avoids the creation of new duplicate applications, and in the other hand I introduced the ability to remove applications from the admin side. So even when we release this to production the old duplicated applications will be there and someone will need to do the clean up manually from the admin side. |
Thank you for the prompt responses, guys! |
Ref: #770
Some improvements on Register & Membership process:
Review register process (create account and confirm email), some users get stuck in this processℹ️ NOTE can't reproduce
ℹ️ NOTE Added ability to remove non-accepted petitions from the admin
ℹ️ NOTE Added
highlighted
flag to avoid hardcoding IDs