Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impove Onboarding / Membership management process #771

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

markets
Copy link
Collaborator

@markets markets commented Dec 29, 2024

Ref: #770

Some improvements on Register & Membership process:

  • Review register process (create account and confirm email), some users get stuck in this process
    ℹ️ NOTE can't reproduce
  • Remember users without membership (15 days after register) they should ask for membership in some Organization or the user will be deleted when user have 1 month on the platform without membersehip
  • Super admin (active admin) allow to filter users without membership (we will manually manage this list and remove old users without membership)
  • Fix duplicate applications. Closes Duplicate applications #763.
    ℹ️ NOTE Added ability to remove non-accepted petitions from the admin
  • Force page https://www.timeoverflow.org/organizations to users logged in without membership (some users don't know what to do if they see pages like https://www.timeoverflow.org/pages/about)
  • Improve text of email notifications new membership application, specify the name of the organization user want to join
  • Notify orgs admins (CCO) when membership remove their membership
  • On https://www.timeoverflow.org/organizations Organizations list place BdTOnline (org 402) always at the begining (it's the TimeBank that you can join if you don't find any in your location)
    ℹ️ NOTE Added highlighted flag to avoid hardcoding IDs

@markets markets linked an issue Dec 29, 2024 that may be closed by this pull request
@markets
Copy link
Collaborator Author

markets commented Jan 2, 2025

@sseerrggii I'm still polishing some details and working in some points, but I'm unable to reproduce the 1st issue 🤔:

Review register process (create account and confirm email), some users get stuck in this process

Do you have more specific information about those problems?

@markets markets marked this pull request as ready for review January 12, 2025 16:55
@markets markets requested a review from franpb14 January 12, 2025 16:55
@markets
Copy link
Collaborator Author

markets commented Jan 12, 2025

@franpb14 Do you want to take a quick look and give me your feedback?

CI is failing due to:

MiniMagick::Error: You must have ImageMagick or GraphicsMagick installed

Maybe something changed in GH Actions 🤔 and now we need to manually install the ImageMagick library?

@@ -6,6 +6,8 @@ def destroy
toggle_active_posts
@member.destroy

OrganizationNotifier.member_deleted(@member).deliver_now
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why deliver_now instead of deliver_later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! I just copy-pasted the same workflow we are already using for emails, but I think this is probably something from the past. I'll move all email delivery to the background queues.

@sseerrggii
Copy link
Contributor

ll polishing some details and working in some points, but I'm unable to reproduce the 1

No problem, we will test whole process

@Mariaadbdt
Copy link

Mariaadbdt commented Jan 14, 2025

Hello team! Thank you very much for the updates! I've been testing some of the features and I’m posting my feedback after each item of the list.

  • Remember users without membership (15 days after register) they should ask for membership in some Organization or the user will be deleted when user have 1 month on the platform without membersehip.

Feedback: I registered as new user and the message reminding me to join a timebank appeared in 3 occasions. Before (https://staging.deploy.timeoverflow.org/members/please_confirm) and after (https://staging.deploy.timeoverflow.org/organizations) confirming the email. Then I logged out and in again and it also appeared upon requesting to join a timebank.

I would suggest keeping it only after the email confirmation and if possible send a reminder email within 15 days. And could you please review the text to make the process a bit clearer? Suggestion: Your registration will be completed once you have requested to join a timebank and the timebank accepts your request. If you do not request to join a timebank within 30 days, your user will be automatically deleted from the system.

  • Super admin (active admin) allow to filter users without membership (we will manually manage this list and remove old users without membership)

Feedback: It works!

  • Fix duplicate applications. Closes

Feedback/query: This is not yet in production, right? In Sants we still see the duplicates.

Feedback: It works both during the registration process and when I logged out and logged in again.

  • Improve text of email notifications new membership application, specify the name of the organization user want to join.

Feedback: OK! And if you consider improving the email that the admins receive, I have a suggestion for the text: “Hello, XXX has just requested to join xxx Timebank. You can enter …. to accept or reject the request. Once you accept the request the user will automatically appear on your users list.”

  • Notify orgs admins (CCO) when membership remove their membership

Feedback: I couldn’t test this but it’s a great feature!

  • On https://www.timeoverflow.org/organizations Organizations list place BdTOnline (org 402) always at the begining (it's the TimeBank that you can join if you don't find any in your location) ℹ️ NOTE Added highlighted flag to avoid hardcoding IDs

Feedback: ok.

Bonus track:
I accidently landed on this page (https://staging.deploy.timeoverflow.org/select_organization) after having deactivated the membership of my new user from the admin panel. In fact, I thought I had deleted the user and restarted the registration process of a new “new account”. I moved from the registration form to this error page. The sentence in the blue square needs revision as well, as it doesn’t give any “further info”. And I’m missing a “next”, “exit”, “continue”, “back” or whatever button to go to another page or suggest a next step.

tof error

@markets
Copy link
Collaborator Author

markets commented Jan 15, 2025

@Mariaadbdt thank you for your feedback! I'm going to address those points in the following days.

@sseerrggii
Copy link
Contributor

sseerrggii commented Jan 15, 2025

Thanks @Mariaadbdt for testing and feedback

This features are not in production, when we approve all the changes @markets will create a new release of TimeOverflow on production

About the suggestion "If you do not request to join a timebank within 30 days, your user will be automatically deleted from the system." In order to no add complexity to this development I will keep this work in manual work of ADBdT (super admin)

@markets
Copy link
Collaborator Author

markets commented Jan 15, 2025

@Mariaadbdt @sseerrggii Note about this point:

Fix duplicate applications

The new code avoids the creation of new duplicate applications, and in the other hand I introduced the ability to remove applications from the admin side. So even when we release this to production the old duplicated applications will be there and someone will need to do the clean up manually from the admin side.

@Mariaadbdt
Copy link

Thank you for the prompt responses, guys!
@sseerrggii you can take out the word "automatic" from the message and just inform that the user will be deleted. I'll add a reminder in my calendar every month to review and delete the unassigned users ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impove Onboarding / Membership management process Duplicate applications
4 participants