-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Benchmark for XSS detection, minor refactor/optimization #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd probably be good to add some test case files with larger strings if it seems like it'd be useful for performance testing, there's no reason to avoid them for unit testing anyways
Can you add some logic to check for, or at least debug that the benchmark is actually running code? Even if the inputs are all small, there are about 60 test case files meaning <1 microsecond per case, this seems too low. Nothing seems obviously wrong with the code from reading it though 🤔 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 90.21% 91.41% +1.20%
==========================================
Files 8 8
Lines 1523 1515 -8
==========================================
+ Hits 1374 1385 +11
+ Misses 128 105 -23
- Partials 21 25 +4 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@M4tteoP Can you push some additional larger texts for #13 (review) ? |
ping @M4tteoP |
This reverts commit 9a8bc1b.
4bc1c8c
to
050015b
Compare
Requires #18 |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
What is needed here? @M4tteoP |
Quality Gate passedIssues Measures |
If you are happy with the additional larger texts added, it is ready to be merged from my side |
I'm always happy. Let's go! |
This PR:
Benchmark Before/After: