Corrected configuration of exclude statements in pre-commit configuration
#2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWenger
changed the title
exclude statements in pre-commit configurationexclude statements in pre-commit configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the pre-commit configuration assumes glob matching in the
excludestatements, even though these are assumed to be regular expressions. This causes the exclude statements to match the wrong files and shows warnings when runningpre-commit.This PR replaces the glob statements with regular expressions in the pre-commit configuration.
Related Issues
This seems to be a common error and similar PRs have been made to other libraries (e.g. openml/openml-python#1129)