Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color value text overflow effect (fix #20) #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ev1ch
Copy link

@Ev1ch Ev1ch commented Dec 27, 2024

This PR propose to fix mentioned in the title issue by limiting color value text width and add text overflow effect

@Ev1ch Ev1ch changed the title Fix color value text overflow effect Fix color value text overflow effect (fix #20) Dec 27, 2024
@AlyssaKirstine
Copy link
Member

@Ev1ch Thanks for fixing this. I'll try to take a better look and test it sometime in the next week.

@Ev1ch
Copy link
Author

Ev1ch commented Dec 27, 2024

@Ev1ch Thanks for fixing this. I'll try to take a better look and test it sometime in the next week.

Thank you for the response.

I was glad to help. This PR was created just to show the easiest way to solve the mentioned issue, so if there are any solutions with better UI/UX, just let me know.

@AlyssaKirstine
Copy link
Member

@Ev1ch It looks like the color value is getting cut off in a weird way for me with this fix.
image

@AlyssaKirstine
Copy link
Member

AlyssaKirstine commented Dec 31, 2024

Maybe for better UI, you could do something more like the following?
image

There are two aspects at play here:

  1. When the color list is collapsed, have the text for the label cut off or with the ellipsis like you intended but still see the down arrow.
  2. And then when the color list is expanded, wrap the text so you can still see it all.

@Ev1ch
Copy link
Author

Ev1ch commented Jan 2, 2025

Hello!

I definitely agree with you, will apply the mentioned approach and return with results.

@Ev1ch
Copy link
Author

Ev1ch commented Jan 3, 2025

Hello.

Added fixed ellipsis effect for color value overflowing. I will be glad to receive feedback/comments on that.
image
image

Also, to handle user corner cases, I propose adding plugin option showColorValue (name can be changed) which specifies whether we should show color value on button or not.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants