Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: First run at interchaintests. #3205

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

fastfadingviolets
Copy link
Contributor

Description

Introduces integration tests using the interchaintest framework.

These include tests for different transaction types, and consumer chain launches. They are triggered by the docker-push workflow and will test the pushed image. They can also be triggered manually and will try to test an image on the branch supplied.

For the gaia team, the main thing to review are the two github workflows.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@fastfadingviolets
Copy link
Contributor Author

You can see these in action in this fork

tests/interchain/chainsuite/chain_ics.go Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this into a standalone module?

This is done by adding a go.mod with required dependencies to the tests/interchain folder.

This would enable us to version the tests separately from the rest of the repository. As far as I can tell, these tests don't actually use anything from the gaia repo so it should be safe to de-couple them.

go.mod Outdated Show resolved Hide resolved
@fastfadingviolets fastfadingviolets marked this pull request as draft July 17, 2024 13:57
@MSalopek MSalopek added the scope: testing Code review, testing, making sure the code is following the specification. label Jul 21, 2024
@fastfadingviolets
Copy link
Contributor Author

@fastfadingviolets fastfadingviolets marked this pull request as ready for review July 24, 2024 16:44
tests/interchain/chainsuite/chain_ics.go Dismissed Show dismissed Hide dismissed
@MSalopek MSalopek changed the title feat: First run at interchaintests. ci: First run at interchaintests. Jul 29, 2024
These include tests for different transaction types, and consumer chain
launches. They are triggered by the docker-push workflow and will test
the pushed image. They can also be triggered manually and will try to
test an image on the branch supplied.
This is used by some features of interchaintest and is just generally
useful to have.
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Administrative approval, thx for the work!

Copy link
Contributor

@LexaMichaelides LexaMichaelides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏼‍♀️ 👍🏼

@MSalopek MSalopek merged commit bb6f13f into cosmos:main Jul 29, 2024
16 checks passed
@fastfadingviolets fastfadingviolets deleted the v19-interchaintest branch July 29, 2024 16:45
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
* First run at interchaintests.

These include tests for different transaction types, and consumer chain
launches. They are triggered by the docker-push workflow and will test
the pushed image. They can also be triggered manually and will try to
test an image on the branch supplied.

* Upgrade interchaintest to v8 and use upstream

* Add jq to the docker image.

This is used by some features of interchaintest and is just generally
useful to have.

(cherry picked from commit bb6f13f)
MSalopek pushed a commit that referenced this pull request Jul 30, 2024
* First run at interchaintests.

These include tests for different transaction types, and consumer chain
launches. They are triggered by the docker-push workflow and will test
the pushed image. They can also be triggered manually and will try to
test an image on the branch supplied.

* Upgrade interchaintest to v8 and use upstream

* Add jq to the docker image.

This is used by some features of interchaintest and is just generally
useful to have.

(cherry picked from commit bb6f13f)

Co-authored-by: violet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v21.x scope: testing Code review, testing, making sure the code is following the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: add interchaintest powered e2e tests and reproducible docker builds
4 participants