Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: avoid state break in wasm #3253

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix!: avoid state break in wasm #3253

merged 2 commits into from
Aug 5, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Aug 2, 2024

@mpoke mpoke requested a review from Reecepbcups August 5, 2024 08:24
@mpoke
Copy link
Contributor

mpoke commented Aug 5, 2024

@Reecepbcups I had to remove the filepath.Join method altogether to fix the linter. afaict, it shouldn't change the behavior, right?

@mpoke mpoke merged commit 538222a into main Aug 5, 2024
17 checks passed
@mpoke mpoke deleted the masa/fix-wasm-dir-path branch August 5, 2024 13:53
mergify bot pushed a commit that referenced this pull request Aug 5, 2024
* fix!: avoid state break in wasm

* fix linter

---------

Co-authored-by: mpoke <[email protected]>
(cherry picked from commit 538222a)
mpoke pushed a commit that referenced this pull request Aug 5, 2024
* fix!: avoid state break in wasm

* fix linter

---------

Co-authored-by: mpoke <[email protected]>
(cherry picked from commit 538222a)

Co-authored-by: MSalopek <[email protected]>
@Reecepbcups
Copy link
Member

correct this is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants