CXXCBC-387: Cache formatted mbcp_session endpoints #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
approved these changes
Oct 22, 2023
avsej
force-pushed
the
optimisation-formatting2
branch
from
842f1c7 to
1a863eb
Compare
…al/remote sessions Profiling indicates that non-trivial time is spent in this logic, which is called on every request. There appears to be no reason not to cache this formatting in the existing variables. When tested together with another optimisation, this resulted in around a 15% performance improvement.
avsej
force-pushed
the
optimisation-formatting2
branch
from
1a863eb to
3ce5451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling indicates that non-trivial time is spent in this logic, which is called on every request.
There appears to be no reason not to cache this formatting in the existing variables, as local_endpoint_address_ is only being used here.
When tested together with another optimisation, this resulted in around a 15% performance improvement.