Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXXCBC-387: fix inconsitency with cached addresses with and without port #464

Merged
merged 1 commit into from
Oct 25, 2023
Merged

CXXCBC-387: fix inconsitency with cached addresses with and without port #464

merged 1 commit into from
Oct 25, 2023

Conversation

avsej
Copy link
Member

@avsej avsej commented Oct 25, 2023

No description provided.

@avsej avsej requested a review from thejcfactor October 25, 2023 20:37
thejcfactor
thejcfactor approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test w/ the Node.js SDK and CouchbaseMock.jar look good now 👍

@avsej avsej merged commit c97ddf8 into couchbase:main Oct 25, 2023
12 of 13 checks passed
@avsej avsej deleted the fix-cached-addresses branch October 25, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejcfactor thejcfactor thejcfactor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avsej @thejcfactor