Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for dukluv compilation in FreeBSD and Linux #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for dukluv compilation in FreeBSD and Linux #9

wants to merge 2 commits into from

Conversation

darkuranium
Copy link

The dukluv binary was failing to compile in FreeBSD and (AFAIK) Linux. This was because libm was not being linked with; the fix is included.

@darkuranium
Merge pull request #1 from creationix/master
9340eb9 
Sync with upstream
@darkuranium
Fix CMakeLists.txt for FreeBSD and Linux
4cf7389 
Compilation was failing in Linux and FreeBSD --- linking with `libm` fixes the problem in these systems.
@darkuranium
Copy link
Author

I've noticed you do have libm linked in Linux, in duktape.cmake --- knowing that, a better option would probably be to fix that file, instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@darkuranium