Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency and notification Improvements to slicer #90

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Dependency and notification Improvements to slicer #90

merged 2 commits into from
Oct 29, 2023

Conversation

pydanny
Copy link
Member

@pydanny pydanny commented Oct 29, 2023

  • Removed unnecessary import checks
  • Used rich.console to improve messaging to user
  • Fixed code formatting/linting using ruff and black

@pydanny pydanny marked this pull request as ready for review October 29, 2023 09:28
audreyfeldroy
audreyfeldroy approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@audreyfeldroy audreyfeldroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @pydanny, thank you!

@audreyfeldroy audreyfeldroy merged commit 87579e1 into main Oct 29, 2023
1 check passed
@audreyfeldroy audreyfeldroy deleted the slicer-print-dependency-improvements branch October 29, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audreyfeldroy audreyfeldroy audreyfeldroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pydanny @audreyfeldroy