[ruff] Enable extra plugins #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A small tip: you should be able to run |
Arno500
approved these changes
Jan 8, 2025
anisse
reviewed
Jan 9, 2025
Comment on lines
33
to
40
| # may raise tarfile.ReadError if tarfilename is not a tar file | ||
| tarfd = tarfile.open(tarfilename, "r") | ||
| try: | ||
| with tarfile.open(tarfilename, "r") as tarfd: | ||
| file = tarfd.extractfile(filename) | ||
| if not file: | ||
| tarfd.close() | ||
| return None | ||
| ret = file.read(-1) | ||
| tarfd.close() | ||
| return ret |
There was a problem hiding this comment.
You lost the initial error handling :-(
There was a problem hiding this comment.
Woops, did not catch this one. Fixed in #71
Arno500
added a commit
that referenced
this pull request
Jan 9, 2025
This was removed in #70 mistakenly
Arno500
added a commit
that referenced
this pull request
Jan 11, 2025
This was removed in #70 mistakenly
anisse
pushed a commit
that referenced
this pull request
Jan 13, 2025
This was removed in #70 mistakenly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable extra plugins for ruff linting