feat: add LogicalInterface model #23
Conversation
djothi
force-pushed
the
logicalinterface
branch
from
36bfd94 to
80f8140
Compare
djothi
force-pushed
the
logicalinterface
branch
2 times, most recently
from
e795522 to
39ce07a
Compare
| default=AssetStateChoices.STATE_STAGING, | ||
| help_text="State of this DeviceInterface", | ||
| ) | ||
| monitoring_state = models.CharField( |
There was a problem hiding this comment.
Not necessarily for this review, but this is more to start discussions about this:
I don't recall if it has been discussed yet, but how do we deal with the monitoring_state if the parent interface says "disabled", and the logical interface says "critical" for instance ? (and vice versa)
I guess we should implement some sort of precedence between these 2 entities. At first sight it would make sense that a parent interface put in "disabled" mode, would override/inhibit the value on the children interface (logical ones).
There was a problem hiding this comment.
IIRC we briefly talked about it, but nothing more. Let's schedule a dedicated meeting. The solution could also impact BGPSession monitoring fields
There was a problem hiding this comment.
it has already been discussed indeed, there was a page and a consensus :)
I'll share the page in slack
EDIT: we are actually missing details about this point in the page.
djothi
force-pushed
the
logicalinterface
branch
from
39ce07a to
5e197b6
Compare
Description:
Add LogicalInterface model.