fix: refactor VLAN model by removing device foreign key #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djothi
force-pushed
the
remove_vlan_device_fk
branch
2 times, most recently
from
3cb8572 to
bba6637
Compare
fdomain
reviewed
Dec 15, 2023
djothi
force-pushed
the
remove_vlan_device_fk
branch
from
bba6637 to
36c6f25
Compare
djothi
force-pushed
the
remove_vlan_device_fk
branch
from
36c6f25 to
d90bef2
Compare
fdomain
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: remove device fk in VLAN model
Description:
This PR refactors the VLAN model by removing the device foreign key. VLANs are attached to a device through a
DeviceLogicalInterface(untagged_vlan/ tagged_vlans or native_vlan)After the commit:
Removes the device foreign key from the VLAN model.