Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add session option for custom ttl function #191

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Munilive
Copy link
Contributor

@Munilive Munilive self-assigned this Apr 15, 2024
@Munilive Munilive requested a review from sixmen April 15, 2024 09:23
@@ -14,6 +14,7 @@ export interface IExpressConfig {
password?: string;
};
ttl: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttl: number | (sess: SessionData) => number 로 하면 되지 않을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵. 그렇게 하려고 했는데 다른대서 쓰셨길래 별도로 만들었어요.

maxAge: config.session.ttl * 1000,

@Munilive Munilive merged commit 194a179 into main Apr 15, 2024
1 check passed
@Munilive Munilive deleted the feature/add-custom-ttl-function branch April 15, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants